how hard would it be to keep this test in core by plugging in a mochk payload filter?

It all depends on if you are testing the term vectors API (stay in core with a mock) or if you are testing something super specific to this token filter. If it is specific, then I'd move it over.

We ESIntegTestCase subclasses to end in either Tests or IT when they are outside of core but since they don't need the Elasticsearch I like to name them like Tests instead of IT.

I'll try move this test back to core and use a mock payload filter.

@jpountz @nik9000 I moved the test to core and added a mock payload tokenizer.
I was unable to use Lucene's MockPayloadAnalyzer because the test relies on specifics of DelimitedPayloadTokenFilter, so I end up coping it here. I think this is ok, since it is a small and not too complex token filter

I think I was trying to keep them in alphabetical order.... No big deal.

I re-arranged the lines in alphabetical order.

It all depends on if you are testing the term vectors API (stay in core with a mock) or if you are testing something super specific to this token filter. If it is specific, then I'd move it over.

We ESIntegTestCase subclasses to end in either Tests or IT when they are outside of core but since they don't need the Elasticsearch I like to name them like Tests instead of IT.

I'd prefer

else {
    return false;
}

Just a bit more balanced looking. No big deal either way I guess.