Skip to content

remove lang url parameter from stored script requests#25779

Merged
jdconrad merged 6 commits intoelastic:masterfrom
jdconrad:rl
Jul 20, 2017
Merged

remove lang url parameter from stored script requests#25779
jdconrad merged 6 commits intoelastic:masterfrom
jdconrad:rl

Conversation

@jdconrad
Copy link
Copy Markdown
Contributor

@jdconrad jdconrad commented Jul 18, 2017

As the title says. Also has updates to ScriptMetaData for allowing the old namespace format to be loaded all the way back through 5.0; however, it will throw an exception if two scripts share the same id but different languages.

Closes #22887

@jdconrad jdconrad added :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v6.0.0 labels Jul 18, 2017
@jdconrad jdconrad requested a review from rjernst July 18, 2017 19:57
Copy link
Copy Markdown
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdconrad jdconrad merged commit 9f7463e into elastic:master Jul 20, 2017
@jdconrad
Copy link
Copy Markdown
Contributor Author

@rjernst and @martijnvg Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>breaking :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v6.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants