Skip to content

Port the remaining old indices search tests to full cluster restart qa module#25275

Merged
martijnvg merged 1 commit intoelastic:masterfrom
martijnvg:port_more_bwc_tests_2
Jun 19, 2017
Merged

Port the remaining old indices search tests to full cluster restart qa module#25275
martijnvg merged 1 commit intoelastic:masterfrom
martijnvg:port_more_bwc_tests_2

Conversation

@martijnvg
Copy link
Copy Markdown
Member

Also tweaked the qa module's gradle file to actually run bwc tests against all index compat versions when executing gradle bwcTest.

Relates to #24939

@martijnvg martijnvg added review >test Issues or PRs that are addressing/adding tests v6.0.0 labels Jun 16, 2017
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ok to use the Version from Version.java.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd pull this to its own test case so it doesn't get confused with the other search tests. We assert with a search but I think this is more about the alias than search in general. I dunno why I feel this way. What do you think?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I'll move it to its own test.

…tart qa module

Also tweaked the qa module's gradle file to actually run bwc tests against all index compat versions.

Relates to elastic#24939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>test Issues or PRs that are addressing/adding tests v6.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants