Move more token filters to analysis-common module#25214
Conversation
There was a problem hiding this comment.
Added a general ngram search rest test to analysis module, so the removal of these lines and above is covered.
There was a problem hiding this comment.
The useAllFields(...) is now tested by changing the default search field to f1 instead of using a custom analyzer with ngram token filters.
There was a problem hiding this comment.
Not a blocker but I think it would be best as a rest-test. My reasoning is that if analysis-common starts depending on highlighters, then highlighters could not be moved to a module, which is something we might want to do at some point.
There was a problem hiding this comment.
I think it'd be nice if this were a rest test too. It can be a java rest test instead of a yaml rest test if that is easier.
There was a problem hiding this comment.
I believe @andy-elastic started a trend to remove the extra spaces. Can you remove the extra spaces in this map while you are modifying it?
There was a problem hiding this comment.
I think it'd be nice if this were a rest test too. It can be a java rest test instead of a yaml rest test if that is easier.
b24bea6 to
892c606
Compare
The following token filters were moved: `edge_ngram`, `ngram`, `uppercase`, `lowercase`, `length`, `flatten_graph` and `unique`. Relates to elastic#23658
892c606 to
428e707
Compare
The following token filters were moved:
edge_ngram,ngram,uppercase,lowercase,length,flatten_graphandunique.Relates to #23658