Move several token filters to common-analysis module#24948
Merged
martijnvg merged 1 commit intoelastic:masterfrom May 31, 2017
Merged
Conversation
75 tasks
nik9000
approved these changes
May 30, 2017
Member
nik9000
left a comment
There was a problem hiding this comment.
Left a minor thing about testing trim but otherwise awesome! Thanks!
Member
There was a problem hiding this comment.
Cool. The pre-configured version of lowercase is in core so this'll work!
Member
There was a problem hiding this comment.
I think maybe test this with the keyword tokenizer instead.
afbafaf to
4b0928f
Compare
…filter factories from core to common-analysis module. Relates to elastic#23658
4b0928f to
258be2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
keyword_marker,trim,snowballandporter_stemmertokenfilter factories from core to common-analysis module.Relates to #23658