Skip to content

Enforce at most one type.#24428

Merged
jpountz merged 3 commits intoelastic:masterfrom
jpountz:enhancement/require_one_type_at_most
May 4, 2017
Merged

Enforce at most one type.#24428
jpountz merged 3 commits intoelastic:masterfrom
jpountz:enhancement/require_one_type_at_most

Conversation

@jpountz
Copy link
Copy Markdown
Contributor

@jpountz jpountz commented May 2, 2017

This is a follow-up to #24317, which did the hard work but was merged in such a
way that it exposes the setting while still allowing indices to have multiple
types by default in order to give time to people who test against master to
add this setting to their index settings.

This is a follow-up to elastic#24317, which did the hard work but was merged in such a
way that it exposes the setting while still allowing indices to have multiple
types by default in order to give time to people who test against master to
add this setting to their index settings.
Copy link
Copy Markdown
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -100,11 +100,10 @@ public enum MergeReason {
static {
Function<Settings, String> defValue = settings -> {
// TODO: uncomment this
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the TODO can be removed.

@jpountz jpountz merged commit d0e7151 into elastic:master May 4, 2017
@jpountz jpountz deleted the enhancement/require_one_type_at_most branch May 4, 2017 08:27
@jbudz jbudz mentioned this pull request May 4, 2017
@clintongormley clintongormley added :Search Foundations/Mapping Index mappings, including merging and defining field types v6.0.0-alpha1 and removed v6.0.0 labels May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>breaking >enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types v6.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants