Added unittests for InternalGeoCentroid#24176
Merged
martijnvg merged 1 commit intoelastic:masterfrom Apr 24, 2017
Merged
Conversation
63 tasks
colings86
approved these changes
Apr 24, 2017
Contributor
colings86
left a comment
There was a problem hiding this comment.
LGTM I left a note about why we endcode and decode the point we generate but maybe just add a comment to the code for future and then merge?
Contributor
There was a problem hiding this comment.
why do we need to encode to a long and decode back to a GeoPoint here?
Member
Author
There was a problem hiding this comment.
Right, we can reuse the current one and just set lat/lon on that. Let me change that.
615ea14 to
dabbf5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #22278