Remove global repositories.azure settings#23262
Merged
dadoonet merged 1 commit intoelastic:masterfrom Mar 31, 2017
Merged
Conversation
Today we have multiple ways to define settings when a user needs to create a repository: * in `elasticsearch.yml` file using `repositories.azure` prefix * when creating the repository itself with `PUT _snaphot/repo` The plan is to: * Deprecate `repositories.azure` settings in 5.x (done with elastic#22856) * Remove in 6.x (this PR) Related to elastic#22800
This was referenced Feb 20, 2017
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Contributor
Author
|
@rjernst Could you please review this? I'd like to merge it. |
Contributor
Author
|
@rjernst I'm planning to merge this one hopefully next week unless you see any blocker. |
Contributor
Author
|
Thanks @s1monw! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today we have multiple ways to define settings when a user needs to create a repository:
elasticsearch.ymlfile usingrepositories.azureprefixPUT _snaphot/repoThe plan is to:
repositories.azuresettings in 5.x (done with Deprecate globalrepositories.azuresettings #22856)Related to #22800