Add unit tests to percentile ranks aggregations.#23240
Merged
jpountz merged 2 commits intoelastic:masterfrom Mar 1, 2017
Merged
Add unit tests to percentile ranks aggregations.#23240jpountz merged 2 commits intoelastic:masterfrom
jpountz merged 2 commits intoelastic:masterfrom
Conversation
63 tasks
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jimczi
reviewed
Mar 1, 2017
| if (false == firstInstance.equals(secondInstance)) { | ||
| firstInstance.equals(secondInstance); | ||
| assertEquals("instance is not equal to its copy", firstInstance, secondInstance); | ||
| } |
Contributor
There was a problem hiding this comment.
Why do you need to remove this assertion ?
Contributor
Author
There was a problem hiding this comment.
Good catch, I wanted only to remove what looked like a debug statement, I pushed a fix.
jimczi
approved these changes
Mar 1, 2017
Contributor
jimczi
left a comment
There was a problem hiding this comment.
Left a small comment regarding the removal of an assertion.
LGTM otherwise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates #22278