Disallow introducing illegal object mappings (double '..')#22891
Merged
dakrone merged 1 commit intoelastic:masterfrom Feb 1, 2017
Merged
Disallow introducing illegal object mappings (double '..')#22891dakrone merged 1 commit intoelastic:masterfrom
dakrone merged 1 commit intoelastic:masterfrom
Conversation
jpountz
approved these changes
Jan 31, 2017
Contributor
There was a problem hiding this comment.
what about splitting first and then checking whether the array contains an empty string? I think that would also cover two other cases we are interested in validating: leading dots and trailing dots? (just thinking out loud)
Contributor
There was a problem hiding this comment.
can you reduce the visibility of this method?
Member
Author
|
Thanks @jpountz, I pushed a commit that addresses your feedback! |
a6c588d to
d19f6af
Compare
Member
Author
|
retest this please |
This disallows object mappings that would accidentally create something like `foo..bar`, which is then unparsable for the `bar` field as it does not know what its parent is. Resolves elastic#22794
9481f94 to
8d83edc
Compare
This was referenced Dec 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This disallows object mappings that would accidentally create something like
foo..bar, which is then unparsable for thebarfield as it does not knowwhat its parent is.
Resolves #22794