Skip to content

Revert "Make build Gradle 2.14 / 3.x compatible (#22669)"#22727

Merged
jasontedor merged 1 commit intoelastic:masterfrom
jasontedor:revert-gradle-2.13
Jan 20, 2017
Merged

Revert "Make build Gradle 2.14 / 3.x compatible (#22669)"#22727
jasontedor merged 1 commit intoelastic:masterfrom
jasontedor:revert-gradle-2.13

Conversation

@jasontedor
Copy link
Copy Markdown
Member

@jasontedor jasontedor commented Jan 20, 2017

This reverts commit 652cb7d.

Relates #22669

@jasontedor jasontedor added :Delivery/Build Build or test infrastructure >non-issue labels Jan 20, 2017
@jasontedor
Copy link
Copy Markdown
Member Author

jasontedor commented Jan 20, 2017

Sorry, but this breaks IntelliJ for both @rjernst and me so this has to be reverted until someone has time to investigate.

@rjernst
Copy link
Copy Markdown
Member

rjernst commented Jan 20, 2017

LGTM

@jasontedor
Copy link
Copy Markdown
Member Author

jasontedor commented Jan 20, 2017

More specifically, with Gradle 2.13, IntelliJ 2016.3, it produces the following:

/Users/jason/src/elastic/elasticsearch/buildSrc/src/main/groovy/org/elasticsearch/gradle/vagrant/VagrantLoggerOutputStream.groovy
Error:(23, 1) Groovyc: unable to resolve class org.gradle.logging.ProgressLogger
Error:(50, 5) Groovyc: unable to resolve class org.gradle.logging.ProgressLogger
/Users/jason/src/elastic/elasticsearch/buildSrc/src/main/groovy/org/elasticsearch/gradle/vagrant/TapLoggerOutputStream.groovy
Error:(25, 1) Groovyc: unable to resolve class org.gradle.logging.ProgressLogger
Error:(41, 5) Groovyc: unable to resolve class org.gradle.logging.ProgressLogger
/Users/jason/src/elastic/elasticsearch/buildSrc/src/main/groovy/com/carrotsearch/gradle/junit4/TestProgressLogger.groovy
Error:(28, 1) Groovyc: unable to resolve class org.gradle.logging.ProgressLogger
Error:(57, 5) Groovyc: unable to resolve class org.gradle.logging.ProgressLogger

@jasontedor jasontedor merged commit 8f6c074 into elastic:master Jan 20, 2017
@jasontedor jasontedor deleted the revert-gradle-2.13 branch January 20, 2017 23:20
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jasontedor @rjernst @mark-vieira