Merged
Conversation
nik9000
approved these changes
Nov 22, 2016
Member
There was a problem hiding this comment.
I think it'd be nice to have an assertion on the text of one description just so we can look at it.
nik9000
approved these changes
Nov 22, 2016
nik9000
reviewed
Nov 22, 2016
Member
There was a problem hiding this comment.
Actually, maybe don't cache it at all?
Contributor
Author
There was a problem hiding this comment.
Good point, will remove that.
Since we added ability to cancel searches it would be nice to see which searches we are actually cancelling.
5b16a95 to
c7b69a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we added ability to cancel searches it would be nice to see which searches we are actually cancelling.