Merged
Conversation
| @@ -299,6 +300,7 @@ public StoreStats stats() throws IOException { | |||
|
|
|||
| public void renameFile(String from, String to) throws IOException { | |||
Contributor
There was a problem hiding this comment.
just remove it, it seems only test use this method now?
Contributor
|
looks great - left some minors |
Contributor
Author
|
I pushed some more commits @s1monw. |
Contributor
|
LGTM |
| this.mapperService = mapperService; | ||
| } | ||
|
|
||
| @Override |
Contributor
There was a problem hiding this comment.
I think you should change the constructor a few lines above in this file to extend PerFieldSimilarityWrapper(defaultSimilarity) rather than the deprecated default constructor?
Contributor
|
I left one comment about SimilarityService but otherwise LGTM |
Contributor
Author
|
Thanks @jpountz, good catch! I pushed a new commit to call |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upgrade was mostly uneventful, except
Completion090PostingsFormathad to switch from an ordinary codec header to an index file header (Lucene now requires this of all files that enter aCFS), andBlobStoreRepository.restoreFilesometimes needs to overwrite an existing file (not sure why, seems dangerous? I left a TODO).Lucene now requires that all files created with
Directory.createOutputare new; I was surprised more places in ES don't seem angry about that.I also fixed
Store.renameTempFilesSafeto only fsync after all files are renamed.Closes #20092