Catch OutOfMemory and StackOverflow errors in Painless#19936
Merged
jdconrad merged 1 commit intoelastic:masterfrom Aug 11, 2016
Merged
Catch OutOfMemory and StackOverflow errors in Painless#19936jdconrad merged 1 commit intoelastic:masterfrom
jdconrad merged 1 commit intoelastic:masterfrom
Conversation
18 tasks
Contributor
|
+1 we made a sandbox, lets take advantage of it :) |
| // Note that it is safe to catch any of the following errors since Painless is stateless. | ||
| } catch (PainlessError | BootstrapMethodError | OutOfMemoryError | StackOverflowError | Exception e) { | ||
| throw convertToScriptException(e); | ||
| } |
Contributor
There was a problem hiding this comment.
thanks for killing this IllegalAccessError: i added this on accident when debugging long ago!
Contributor
Author
|
@rmuir Thanks for the review and pointing out the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Painless is both sandboxed and stateless, it is safe to catch OutOfMemory and StackOverflow errors. This prevents the users from destroying a node if they happen to write a script that is ridiculous like the following:
int[] x = new int[Integer.MAX_VALUE];There is no reason to halt the entire application for the above script.