Forbid the usage or range queries with a range based on current time in percolator queries#19327
Merged
martijnvg merged 1 commit intoelastic:masterfrom Jul 8, 2016
Conversation
Contributor
|
LGTM |
… the current time If there are percolator queries containing `range` queries with ranges based on the current time then this can lead to incorrect results if the `percolate` query gets cached. These ranges are changing each time the `percolate` query gets executed and if this query gets cached then the results will be based on how the range was at the time when the `percolate` query got cached. The ExtractQueryTermsService has been renamed `QueryAnalyzer` and now only deals with analyzing the query (extracting terms and deciding if the entire query is a verified match) . The `PercolatorFieldMapper` is responsible for adding the right fields based on the analysis the `QueryAnalyzer` has performed, because this is highly dependent on the field mappings. Also the `PercolatorFieldMapper` is responsible for creating the percolate query.
e83e8e8 to
ff5527f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are percolator queries containing
rangequeries with ranges based on the current time then this can lead to incorrect results if thepercolatequery gets cached. These ranges are changing each time thepercolatequery gets executed and if this query gets cached then the results will be based on how the range was at the time when thepercolatequery got cached.The ExtractQueryTermsService has been renamed
QueryAnalyzerand now only deals with analyzing the query (extracting terms and deciding if the entire query is a verified match) . ThePercolatorFieldMapperis responsible for adding the right fields based on the analysis theQueryAnalyzerhas performed, because this is highly dependent on the field mappings. Also thePercolatorFieldMapperis responsible for creating the percolate query.