Make shard store fetch less dependent on the current cluster state, both on master and non data nodes#19044
Merged
bleskes merged 11 commits intoelastic:masterfrom Jun 27, 2016
Merged
Conversation
| public static String[] ALL_NODES = Strings.EMPTY_ARRAY; | ||
|
|
||
| /** | ||
| * the list of nodesIds that will be used to resolve this request, once resolved this array will by nulled and {@link #concreteNodes} |
Contributor
|
Left minor comments. Also there is a word missing in the title ;-) |
Contributor
Author
|
@ywelsch thx. I pushed another commit |
Contributor
|
Left one more comment (to get rid of a line of code). Feel free to push once addressed. LGTM |
Contributor
Author
|
thanks @ywelsch ! I added the assertion and pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#18938 has changed the timing in which we send out to nodes to fetch their shard stores. Instead of doing this after the cluster state resulting of the node's join was published, #18938 made it be sent concurrently to the publishing processes. This revealed a couple of points where the shard store fetching is dependent of the current state of affairs of the cluster state, both on the master and the data nodes. The problem discovered were already present without #18938 but required a failure/extreme situations to make them happen.This PR tries to remove as much as possible of these dependencies making shard store fetching simpler and make the way to re-introduce #18938 which was reverted.
These are the notable changes: