Read Elasticsearch manifest via URL#18999
Merged
jasontedor merged 1 commit intoelastic:masterfrom Jun 21, 2016
jasontedor:build-info-url
Merged
Read Elasticsearch manifest via URL#18999jasontedor merged 1 commit intoelastic:masterfrom jasontedor:build-info-url
jasontedor merged 1 commit intoelastic:masterfrom
jasontedor:build-info-url
Conversation
This commit modifies reading the Elasticsearch jar manifest via the URL instead of converting the URL to an NIO path for increased portability.
Member
|
LGTM. It'd be nice to have a test for this because it looks finicky but I can see that that same finicky nature makes it hard to test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit modifies reading the Elasticsearch jar manifest via the URL
instead of converting the URL to an NIO path for increased portability.
Closes #18996