Infer lambda arguments/return type#18983
Merged
rmuir merged 1 commit intoelastic:masterfrom Jun 20, 2016
Merged
Conversation
Contributor
|
LGTM! |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We setup lambdas with optional typing and return value of
def. But if we know the functional interface, we should use the type info we have, and replace alldefwith the real type.Today things work, but for example all Predicate's return values are boxed for no good reason.
Of course the worst case is primitive specializations of interfaces:
Instead of:
We do:
In order for things to be consistent, I added the ability to call methods on primitive types so that we can always replace
defwith its corresponding primitive if needed and it behaves the same.