Merged
Conversation
Contributor
|
LGTM |
Contributor
|
@rmuir LGTM too. Thanks for getting lambdas working! |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Painless has working lambdas now but they are incomplete, can't capture any variables from the current scope.
This adds capture support. To keep it simple nodes get a new
extractVariables(Set<String>)to push their variable names. We call this on the lambda body before analysis to give us the capture info we need.Captures work slightly differently than in java. In java they must be effectively final variables. Instead in painless they are marked read-only inside the lambda body (so you cannot assign them to a different value inside the lambda, as that would not do anything).