Refactor painless variables handling#18951
Merged
rmuir merged 1 commit intoelastic:masterfrom Jun 18, 2016
Merged
Conversation
18 tasks
Contributor
|
LGTM! @rmuir Thanks for making the scoping for variables much more clear! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently very limiting, there is a manually managed stack (with slower access), various nodes saving away bytecode variable slot numbers, nodes changing program state in analyze(), etc.
I refactored it enough to move lambda logic out of Walker into ELambda node. For captures we will have to do a little bit more (our choices are to analyze twice, or do a more complicated variable renumbering).
I think its a good stopping point as the changes impact a lot of code.