Remove support for sorting terms aggregation by ascending count#18940
Merged
jimczi merged 1 commit intoelastic:masterfrom Jun 17, 2016
jimczi:terms_count_asc
Merged
Remove support for sorting terms aggregation by ascending count#18940jimczi merged 1 commit intoelastic:masterfrom jimczi:terms_count_asc
jimczi merged 1 commit intoelastic:masterfrom
jimczi:terms_count_asc
Conversation
Contributor
There was a problem hiding this comment.
should it be s/desc/asc/ ?
Contributor
|
LGTM, can you put a comment on elastic/kibana#6833 saying we are moving forward on this? |
Contributor
Author
|
Sure, thanks @jpountz ! |
Contributor
|
@jimferenczi Let's add deprecation logging on 2.4/2.x? |
Contributor
Author
|
The functionality is deprecated in 2.4/2.x but this PR has been reverted since it requires changes in Kibana. I'll merge it after the alpha release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #17614