Merged
Conversation
Contributor
|
LGTM! |
18 tasks
Contributor
|
Is |
Contributor
Author
|
It was never used. See the TODO in the code. It will be used for captures, because we have to push logic into a node to support that. We have to do analysis first to even know which case it is (or its too crazy). |
Contributor
|
Yeah, that what I expected. |
Contributor
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syntax for this was added in #18824 as a stub.
This adds the non-capturing case. Walker just handles it the same array method references. I think we should do this first and iterate (i found some screwy unrelated bugs in casts already just playing around). The capturing case can be a followup.
Semantics are simple:
defdefunless the user specifies.