fix bugs in operators and more improvements for the dynamic case#18899
Merged
rmuir merged 20 commits intoelastic:masterfrom Jun 15, 2016
Merged
fix bugs in operators and more improvements for the dynamic case#18899rmuir merged 20 commits intoelastic:masterfrom
rmuir merged 20 commits intoelastic:masterfrom
Conversation
|
|
||
| /** | ||
| * Called when a new type is encountered (or, when we have encountered more than {@code MAX_DEPTH} | ||
| * types at this call site and given up on caching using this fallback wand we switch to a |
Contributor
There was a problem hiding this comment.
I think 'wand' should be 'and' here?
Contributor
|
This looks awesome! +1 Thanks @rmuir and @uschindler |
18 tasks
Contributor
Author
|
Thanks for tackling that cache @uschindler ! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a few bugs:
Improve some performance:
Add lots of tests.
I tested the benchmark script by disabling some caches manually:
So Uwe's cache really helps the worst case scenario, where tons of types are seen. Its no longer trappy now :)