Merged
Conversation
| void write(MethodWriter writer) { | ||
| // can cause class cast exception among other things at runtime | ||
| writer.writeDebugInfo(location); | ||
|
|
Contributor
There was a problem hiding this comment.
I think we want to restore the debug information here? since it can hit classcastexception in other cases, its safe to just do it always?
Contributor
Author
There was a problem hiding this comment.
Sounds good to me. I wasn't sure it was safe given that it was only cat before.
Contributor
There was a problem hiding this comment.
its always safe to emit debug information. I've been trying to do it 'smartly' but if things are dicey, its not the end of the world to emit "extra useless" debug info. In this case I know its needed for some error cases (by inspecting error messages from our test), that is why i changed it recently
18 tasks
Contributor
|
+1 this is a big win. |
Contributor
Author
|
Thanks @rmuir for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to use Java-style for each loops on non-def target types.
Also added some documentation in a few other places.