Throw IllegalStateException when handshake fails due to version or cluster mismatch#18676
Merged
s1monw merged 2 commits intoelastic:masterfrom Jun 1, 2016
Merged
Throw IllegalStateException when handshake fails due to version or cluster mismatch#18676s1monw merged 2 commits intoelastic:masterfrom
s1monw merged 2 commits intoelastic:masterfrom
Conversation
…uster mismatch We do throw ConnectTransportException which is logged in trace level hiding a potentially important information when an old or wrong node wants to connect. We should throw ISE and log as warn.
Contributor
|
LGTM. I think we should go further and change https://github.com/elastic/elasticsearch/pull/18676/files#diff-029ce303f3503d9f33f0974c76f69918R356 to also throw a hard exception - we already succesfully connected to that node. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do throw ConnectTransportException which is logged in trace level hiding a potentially
important information when an old or wrong node wants to connect. We should throw ISE and
log as warn.