improve date api for expressions/painless fields#18658
Merged
rmuir merged 1 commit intoelastic:masterfrom May 31, 2016
Merged
Conversation
Member
|
LGTM |
Contributor
|
LGTM also! |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScriptDocValues.Longs exposes a
.datemember that other scripting engines use to get convenient access to date components.For example
doc['field'].date.monthOfYear.Expressions does this inconsistently, it supports a few (but not all) of these methods, but via a different syntax without the
.date, and sometimes with different semantics (!) because it uses java.util.Calendar.For expressions this pr adds
.dateworking the same way/syntax is it does for other engines, and undocuments the old methods: the old methods are left unchanged for anything using them. For painless it adds ReadableDateTime to the whitelist so the same syntax works there too.We can also fix a few other inconsistencies in expressions, like supporting
.length/.size()for the count of values for the field to match other engines: this way its more of a proper subset for most uses.