Closed
Conversation
18 tasks
| import org.elasticsearch.painless.MethodWriter; | ||
|
|
||
| /** | ||
| * Represents a variable load/store. |
Contributor
Author
There was a problem hiding this comment.
Good catch. Copy and paste error. Fixed!
Contributor
|
I love that this is fixed, thanks for doing all this work to do it the clean way, it will be worth it! I left minor comments but looks great. With antlr 4 this is the best we can do, fail on this stuff in tests, and test everything. See this explanation: https://groups.google.com/d/msg/antlr-discussion/z8otgVzqB7I/IAHEU9keZLgJ |
Contributor
Author
|
@rmuir Thanks for the review and all the help debugging! Glad you caught the issue. |
Contributor
Author
|
This was merged, but squashed due to 30 unimportant commit messages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title plus a bit of clean up.