Remove input, support params instead#18287
Merged
rmuir merged 1 commit intoelastic:masterfrom May 12, 2016
Merged
Conversation
Contributor
|
LGTM. |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users don't need to go thru a
inputmap anymore to do things with painless. They can access_score,doc,ctx,_valueetc directly, and those are first-class citizens and optimized to one degree or another to be fast, with any typing (e.g. map) we can use.So typically this map in most cases only used to access
paramsfrom the user Because of that I think we should name it exactly that, it makes usage intuitive:Also I updated some outdated syntax in various places to try to make things better.