Decouple ANTLR AST from Painless#18286
Closed
jdconrad wants to merge 59 commits intoelastic:masterfrom
Closed
Conversation
18 tasks
Contributor
|
Overall looks good. +1 to push once its synced up with master!!!!! I find it easier to understand than the current organization. Thanks for the package docs and other things that make it easier to navigate the code, if you are not so familiar with it. |
Contributor
Author
|
Thanks @rmuir for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a new Painless Tree for analysis/writing to decouple the ANTLR AST and to allow new forms of input to be developed.