Merged
Conversation
Contributor
|
LGTM. Thanks! |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently access to a document works only as
input.doc['field'].value.It would be much better to support
doc['field'].valuelike the other scripting engines.I plan to also followup with
ctxand_valuereserved words, too. After we've done these, I think we should renameinputtoparamsas that will be its general use, just accessing script parameters.This change is the simplest step, it just treats
docas adeftype. It is at least a small perf improvement on its own.Later, we can try to improve its type safety, ultimately treating it as a
Map<String,ScriptDocValues>which will potentially allow us to avoid tons of dynamic shit for what really should not be dynamic...