Implement needsScore() correctly.#18247
Merged
rmuir merged 4 commits intoelastic:masterfrom May 10, 2016
Merged
Conversation
Contributor
Author
|
I ported over the test expressions is using here. Basically we just apply a marker interface if scores are needed and then we can check with Separately we should followup with the special score handling. Maybe the scoreAccessor should not just be shoved into the |
Contributor
|
Interface is fine, annotation is IMHO too complicated, but can be done without much changes. |
Contributor
|
LGTM. |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scripts have to report whether or not they use this. If they don't need
_scorethen e.g. more things can be cached, for example queries.Expressions is currently the only scripting language that doesn't always return
truefor this method. But because we have special handling for it, we should make us of this info and record if its needed.