Closed
Conversation
Contributor
|
I'll review it. This should be a huge win. Today we don't support Being able to support |
| public static String charToString(final char value) { | ||
| return "" + value; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Can we do this one as String.valueOf? https://docs.oracle.com/javase/7/docs/api/java/lang/String.html#valueOf%28char%29
Contributor
|
Looks good. I pushed a commit with some docs and tests changes and ran benchmarks. |
Contributor
Author
|
Used merge --squash. This made it into master. |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added single-quoted strings to Painless + tests.
Added String -> char and char -> String casting.
Fixed a minor bug related to statically-typed shortcuts in lists.