[Ingest] add node.ingest setting that controls whether ingest is active#15610
Conversation
There was a problem hiding this comment.
this makes me wonder: if a node has node.ingest set to false, for sure no processors should run, hence simulate should be off and IngestDisabledActionFilter should throw exception when a pipeline_id is used as it does now. But how about crud actions for pipelines? One has to go to specific nodes to store them, that have node.ingest set to true? this may not be needed, as those are just index, delete and get operations that any node supports...it's like making client nodes reject index requests, they can forward them to the proper nodes, no problem with that.
There was a problem hiding this comment.
also disabling put delete and get actions on the rest layer doesn't disable them on the transport layer, I think we should remove that part.
There was a problem hiding this comment.
oh sorry I see that you don't register the transport action when ingest is off, sorry I had missed that.
|
I reviewed this and my comments were only about disabling put, delete and get template when |
|
that was a LGTM then :) |
|
The idea is that for now clients have to be aware to what nodes they send ingest requests too and enabling indexing with a pipeline enabled. So I felt it is okay to disable both index/bulk requests with a pipeline enabled and the ingest APIs if |
…or not. Defaults to `false`. If `node.ingest` isn't active then ingest related API calls fail and if the `pipeline_id` parameter is set then index and bulk requests fail.
17cfaa7 to
dbbb296
Compare
Defaults to
false.If
node.ingestisn't active then ingest related API calls fail and if thepipeline_idparameter is set then index and bulk requests fail.