Merged
Conversation
43 tasks
Member
There was a problem hiding this comment.
good catch. I must have missed those sleeps.
Member
|
LGTM |
Contributor
Author
There was a problem hiding this comment.
hey @mvg question: I think we should create a list of maps in this case too? thinking more about it, not sure this special case that throws exception makes sense anymore.
Member
There was a problem hiding this comment.
good point. I didn't think about that. The value to append can be an json object too, so yes the exception should be replaced with logic to deal with that.
a1f83f6 to
a8d7cc2
Compare
Contributor
Author
|
heya @martijnvg I updated the PR. |
Member
|
LGTM |
The append processor allows to append one or more values to an existing list; add a new list with the provided values if the field doesn't exist yet, or convert an existing scalar into a list and add the provided values to the newly created list. This required adapting of IngestDocument#appendFieldValue behaviour, also added support for templating to it. Closes elastic#14324
f4c3ad3 to
46f99a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The append processor allows to append one or more values to an existing list; add a new list with the provided values if the field doesn't exist yet, or convert an existing scalar into a list and add the provided values to the newly created list.
This required adapting of IngestDocument#appendFieldValue behaviour, also added support for templating to it.
Closes #14324