Aggregations Refactor: Refactor Top Hits Aggregation#15566
Merged
colings86 merged 1 commit intoelastic:feature/aggs-refactoringfrom Dec 21, 2015
colings86:refactor/tophitsAgg
Merged
Aggregations Refactor: Refactor Top Hits Aggregation#15566colings86 merged 1 commit intoelastic:feature/aggs-refactoringfrom colings86:refactor/tophitsAgg
colings86 merged 1 commit intoelastic:feature/aggs-refactoringfrom
colings86:refactor/tophitsAgg
Conversation
Contributor
There was a problem hiding this comment.
can you aligne indentation with existing code?
Contributor
Author
There was a problem hiding this comment.
I just pushed a commit to address these issues. Hopefully I managed to catch them all
Contributor
|
This looks good to me. The FetchPhase wiring is a bit invasive but I have no idea how to make it better. :( |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.