Aggregations Refactor: Refactor Sampler Aggregation#15418
Merged
colings86 merged 1 commit intoelastic:feature/aggs-refactoringfrom Dec 21, 2015
colings86:refactor/samplerAgg
Merged
Aggregations Refactor: Refactor Sampler Aggregation#15418colings86 merged 1 commit intoelastic:feature/aggs-refactoringfrom colings86:refactor/samplerAgg
colings86 merged 1 commit intoelastic:feature/aggs-refactoringfrom
colings86:refactor/samplerAgg
Conversation
Contributor
Author
|
Note that this PR includes splitting the sampler aggregation into "sampler" and "diversified_sampler" aggregations for the API to make validation and parsing easier |
97cbdb8 to
b147bf3
Compare
Contributor
There was a problem hiding this comment.
is there value in keeping this commented out?
Contributor
|
I actually like the split. I'm wondering that we might rename |
4fbfde6 to
cbcccb3
Compare
Contributor
Author
|
@jpountz I pushed a commit with your suggestions implemented. I'm not a fan of |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.