why can't this plugin use mustache via the scriptengine service? Sorry: I don't think we should have secret embedded script engines inside other plugins. I have found this before and it seriously pisses me off, we can't do this.

@rmuir That is the plan. The ingest framework has been directly using mustache, because it can't directly depend on the script service. It needs to be ES agnostic. In a follow up PR, I plan to add a TemplateService (or something like that) that the ingest framework will use directly. The implementation in the ingest plugin will then use lang-mustache module via the script service.

The ingest framework has been directly using mustache, because it can't directly depend on the script service. It needs to be ES agnostic

This makes no sense.

In a follow up PR, I plan to add a TemplateService (or something like that) that the ingest framework will use directly.

This makes no sense.

Please, lets just use the scriptengineservice, and lookup "mustache", it is really just that simple.

This makes no sense.

why? The processors themselves cannot depend on ES specific codebase. The reason for this is that we want to reuse the processors in LS. So in order to have processors use templates, we need to have some sort of a Template abstraction (I think that's what @martijnvg refers to with TemplateService) that is part of the ingest code (at least the code that will be shared with LS).

This does not justify forking scripting engines, sorry. It needs to go thru the script engine service.

The processors themselves cannot depend on ES specific codebase.

I wonder if that is a good excuse to yank the some of the ES code base into a library you can share.

our script engine support is not something that needs to become a library, its out of the question. We do everything possible to contain their craziness.

@rmuir @uboness I've updated the PR. Ingest no longer has a mustache compile time dependency and indirectly depends on the lang-mustache module. I've added a TemplateService interface to avoid that the ingest framework gets a compile dependency on ES. The ingest plugin provides an implementation that uses ES' script service.

I wonder if that is a good excuse to yank the some of the ES code base into a library you can share.

@nik9000 Indirectly using the script service in ingest avoids granting permissions in ingest that a template engine may need. Also it has already been granted in the lang-moustache module, so no need to grant twice.

@javanna I've updated this PR.