Allocate primary shards based on allocation IDs#15281
Merged
ywelsch merged 1 commit intoelastic:masterfrom Dec 17, 2015
Merged
Conversation
7 tasks
Contributor
There was a problem hiding this comment.
call this lastActiveAllocationIds?
Contributor
Author
|
Pushed changes related to our discussion:
|
Contributor
There was a problem hiding this comment.
That Allocation enum is really confusing in this context (I stumbled on this 3 times now). This is unrelated to this change, so I'm not suggesting we change it here - but do you have suggestions for a better name? maybe AllocatedAs ?
Contributor
Author
There was a problem hiding this comment.
What about AllocationStatus? The JSON field should also be adapted.
Contributor
There was a problem hiding this comment.
I liked allocatedAs better :) (note that the name of the java JSON field is ALLOCATED :))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TransportNodesListGatewayStartedShardsaction./some_index/_shard_stores)Relates to #14739