Aggregations Refactor: Refactor Bucket Selector Aggregation#15147
Merged
colings86 merged 1 commit intoelastic:feature/aggs-refactoringfrom Dec 7, 2015
colings86:refactor/bucketSelectorAgg
Merged
Aggregations Refactor: Refactor Bucket Selector Aggregation#15147colings86 merged 1 commit intoelastic:feature/aggs-refactoringfrom colings86:refactor/bucketSelectorAgg
colings86 merged 1 commit intoelastic:feature/aggs-refactoringfrom
colings86:refactor/bucketSelectorAgg
Conversation
Member
There was a problem hiding this comment.
Is this new or code that was moved? I was looking for where this came from but couldn't find anything.
Contributor
Author
There was a problem hiding this comment.
This is new but reflects the same output as BucketSelectorBuilder provides
Member
|
Looks good to me, left one question and a general remark concerning the way reading/writing objects is spread across abstract classes and implementations, but this is something than can be revisited later. |
Contributor
Author
There was a problem hiding this comment.
Will do. This is actually the same change as made in #15014 where I have already added JavaDocs. I will make sure that one is merged first and the JavaDoc is retained
Contributor
|
LGTM |
cd3937d to
f386661
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.