[Ingest] Add meta processor that allows to modify the metadata attributes of document being processed#14991
Merged
martijnvg merged 1 commit intoelastic:feature/ingestfrom Nov 26, 2015
Conversation
Contributor
There was a problem hiding this comment.
I think see the point of not setting the source if it was not modified, but when it comes to metadata, should we just set them back all the time? anyway we end up with a single flag for all of them...
Member
Author
There was a problem hiding this comment.
right, I'll remove the metadata flag.
Contributor
|
left a few comments, I like it! |
fa7e8f1 to
b2d2b10
Compare
Contributor
There was a problem hiding this comment.
I think this comment is outdated :)
Contributor
|
left two super minor comments, LGTM though, no need for another review |
b2d2b10 to
01d391b
Compare
…butes of document being processed
01d391b to
9d1fa0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adds template support only for the new
metaprocessor. I opened #14990 to discuss how template support should further be adopted in ingest.PR for #14644