Skip to content

Aggregations Refactor: Refactor Geobounds Aggregation#14934

Merged
colings86 merged 1 commit intoelastic:feature/aggs-refactoringfrom
colings86:refactor/geoBoundsAgg
Nov 24, 2015
Merged

Aggregations Refactor: Refactor Geobounds Aggregation#14934
colings86 merged 1 commit intoelastic:feature/aggs-refactoringfrom
colings86:refactor/geoBoundsAgg

Conversation

@colings86
Copy link
Copy Markdown
Contributor

@colings86 colings86 commented Nov 23, 2015

No description provided.

@clintongormley clintongormley mentioned this pull request Nov 23, 2015
Closed
jpountz
jpountz reviewed Nov 23, 2015
View reviewed changes
...c/main/java/org/elasticsearch/search/aggregations/metrics/geobounds/GeoBoundsAggregator.java Outdated
Copy link
Copy Markdown
Contributor

@jpountz jpountz Nov 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we reduce visibility? eg. pkg-private

@jpountz
Copy link
Copy Markdown
Contributor

jpountz commented Nov 23, 2015

LGTM, I just left minor comments

@colings86 colings86 force-pushed the feature/aggs-refactoring branch from 543a61f to 7df641c Compare November 24, 2015 08:50
@colings86 colings86 merged commit db37977 into elastic:feature/aggs-refactoring Nov 24, 2015
@colings86 colings86 deleted the refactor/geoBoundsAgg branch November 24, 2015 09:33
@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :Search Refactoring labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

:Analytics/Aggregations Aggregations :Search/Search Search-related issues that do not fall into other categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colings86 @jpountz @clintongormley