CsvAssert: accept KEYWORD vs TEXT metadata in mixed-cluster csv-spec#145474
Open
wchaparro wants to merge 2 commits intoelastic:mainfrom
Open
CsvAssert: accept KEYWORD vs TEXT metadata in mixed-cluster csv-spec#145474wchaparro wants to merge 2 commits intoelastic:mainfrom
wchaparro wants to merge 2 commits intoelastic:mainfrom
Conversation
Mixed-cluster BWC runs can report TEXT for EXTERNAL string columns while csv-spec expects KEYWORD (e.g. external-basic scoreFunction / topSnippetsFunction). Block-level checks already treat KEYWORD bytes as compatible with TEXT; align metadata assertion the same way. Fixes elastic#145352 Fixes elastic#145353 Made-with: Cursor
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mixed-cluster
MixedClusterEsqlSpecITfailures forexternal-basic.scoreFunctionandexternal-basic.topSnippetsFunctioncompared column types asKEYWORD != TEXTat response metadata while block-level assertions already treatKEYWORDblocks as compatible withTEXTexpectations.Change
In
CsvAssert.assertMetadata, treatKEYWORD↔TEXTas compatible for column type metadata (same string-family relaxation as the inner block check).Confidence
~85% — narrow test-harness alignment with existing block rules; does not change product ES|QL typing.
Tests
./gradlew :x-pack:plugin:esql:test --tests "org.elasticsearch.xpack.esql.CsvTests" -Dtests.method="test {csv-spec:external-basic.scoreFunction}" -Dtests.method="test {csv-spec:external-basic.topSnippetsFunction}" -Dtests.seed=DEADBEEFFixes #145352
Fixes #145353
Made with Cursor