Fix CsvIT to check test capabilities#144465
Closed
craigtaverner wants to merge 1 commit intoelastic:mainfrom
Closed
Fix CsvIT to check test capabilities#144465craigtaverner wants to merge 1 commit intoelastic:mainfrom
craigtaverner wants to merge 1 commit intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
| ); | ||
| } else { | ||
| for (EsqlCapabilities.Cap c : EsqlCapabilities.Cap.values()) { | ||
| if (false == c.isEnabled()) { |
Contributor
There was a problem hiding this comment.
Is above condition equivalent to what we have in enabledCapabilities?
Contributor
Author
There was a problem hiding this comment.
It sure looks like it. I just moved this code from CsvTests, and must assume the reason they wrote a longer loop here was so that the error message would be clearer. But in reality I think this could be simplified. I did not attempt that just because my goal was to get CsvIT fixed asap.
Contributor
There was a problem hiding this comment.
Sounds good. Lets do that separately later.
e13cb67 to
a43d582
Compare
idegtiarenko
approved these changes
Mar 18, 2026
Contributor
Author
|
Closing in favor of #144470 which includes this work and fixes other failing release tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So it turns out that CsvIT does not check test capabilities at all. The main consequence is in release tests, where all SNAPSHOT-only features result in test failure.