ESQL: Fix review feedback and add test coverage for PR #143703#143900
Merged
costin merged 2 commits intoelastic:mainfrom Mar 10, 2026
Merged
ESQL: Fix review feedback and add test coverage for PR #143703#143900costin merged 2 commits intoelastic:mainfrom
costin merged 2 commits intoelastic:mainfrom
Conversation
Fix String.format to use Locale.ROOT in ParallelParsingBenchmark (bpintea review comment). Add unit tests for findNextRecordBoundary in CsvFormatReader and NdJsonFormatReader covering quote-aware boundary detection, CRLF handling, buffer edge cases, and EOF. Extend ColumnBlockConversionsTests with repeating null, array copy, and larger-array edge cases for int/boolean/doubleFromLongs. Add RangeStorageObjectTests for readBytes with non-zero position, exact-size buffers, and partial reads.
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @costin, I've created a changelog YAML for you. |
bpintea
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address review feedback from bpintea on PR #143703 and close test
coverage gaps identified in the columnar I/O and parallel parsing
changes.
Fix
String.formatto useLocale.ROOTinParallelParsingBenchmark(bpintea review comment). Add dedicated unit tests for the
findNextRecordBoundaryimplementations inCsvFormatReader(RFC 4180quote-aware boundary detection, escaped quotes, buffer edge cases) and
NdJsonFormatReader(newline, CRLF, CR-only, buffer split). ExtendColumnBlockConversionsTestswith parity edge cases forintColumnFromLongs,booleanColumnFromLongs, anddoubleColumnFromLongs(repeating null, array copy independence, largerarray than row count). Add
RangeStorageObjectTestsscenarios forreadByteswith non-zero position, exact-size buffers, and partialreads from the middle of a range.
Developed using AI-assisted tooling.