Skip to content

Reject search requests with seq_no_primary_term when sequence numbers are disabled#143759

Merged
romseygeek merged 1 commit intoelastic:mainfrom
romseygeek:seqno/remove-seqno-from-query-response
Mar 9, 2026
Merged

Reject search requests with seq_no_primary_term when sequence numbers are disabled#143759
romseygeek merged 1 commit intoelastic:mainfrom
romseygeek:seqno/remove-seqno-from-query-response

Conversation

@romseygeek
Copy link
Copy Markdown
Contributor

No description provided.

@romseygeek romseygeek requested review from fcofdez, kkrik-es and tlrx March 6, 2026 16:43
@romseygeek romseygeek self-assigned this Mar 6, 2026
@romseygeek romseygeek added >non-issue :Search/Search Search-related issues that do not fall into other categories v9.4.0 labels Mar 6, 2026
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Mar 6, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search (Team:Search)

Copy link
Copy Markdown
Contributor

@fcofdez fcofdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +68 to +70
"requesting seq_no_primary_term is rejected":
- do:
catch: bad_request
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this needs to be guarded by a testclusterfeature.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole test file is gated on the disable_sequence_numbers capability.

@romseygeek romseygeek merged commit d032e1f into elastic:main Mar 9, 2026
36 checks passed
@romseygeek romseygeek deleted the seqno/remove-seqno-from-query-response branch March 9, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants