Reject OCC and updates on seq-no-disabled indices#143746
Merged
fcofdez merged 13 commits intoelastic:mainfrom Mar 9, 2026
Merged
Reject OCC and updates on seq-no-disabled indices#143746fcofdez merged 13 commits intoelastic:mainfrom
fcofdez merged 13 commits intoelastic:mainfrom
Conversation
Indices with sequence numbers disabled cannot support optimistic concurrency control or updates. Reject these operations early in InternalEngine and UpdateHelper with dedicated exception types (OCCNotSupportedException, UpdateNotSupportedException) returning HTTP 400.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
fcofdez
commented
Mar 6, 2026
server/src/main/java/org/elasticsearch/index/engine/InternalEngine.java
Outdated
Show resolved
Hide resolved
19 tasks
Contributor
Author
|
@elasticmachine update branch |
…-disabled-indices
…cofdez/elasticsearch into reject-occ-for-seq-no-disabled-indices
tlrx
approved these changes
Mar 9, 2026
|
|
||
| public void testSingleUpdateOnSeqNoDisabledIndexIsRejected() { | ||
| assumeTrue("Test requires disable_sequence_numbers feature flag", IndexSettings.DISABLE_SEQUENCE_NUMBERS_FEATURE_FLAG); | ||
| internalCluster().ensureAtLeastNumDataNodes(1); |
Member
There was a problem hiding this comment.
nit: I think we can let the test framework set up a random number of nodes for the test here.
| ); | ||
| ensureGreen("test"); | ||
|
|
||
| prepareIndex("test").setId("1").setSource("value", "original").get(); |
server/src/main/java/org/elasticsearch/index/engine/InternalEngine.java
Outdated
Show resolved
Hide resolved
…-disabled-indices
…-disabled-indices
Contributor
Author
|
@elasticmachine update branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indices with sequence numbers disabled cannot support
optimistic concurrency control or updates. Reject these
operations early in InternalEngine and UpdateHelper with
dedicated exception types (OCCNotSupportedException,
UpdateNotSupportedException) returning HTTP 400.
Relates to #136305