Skip to content

Remove obsolete branch for finalizing incomplete shards#143721

Merged
elasticsearchmachine merged 3 commits intoelastic:mainfrom
ywangd:remove-dead-branch-for-finalize-incomplete-shards
Mar 10, 2026
Merged

Remove obsolete branch for finalizing incomplete shards#143721
elasticsearchmachine merged 3 commits intoelastic:mainfrom
ywangd:remove-dead-branch-for-finalize-incomplete-shards

Conversation

@ywangd
Copy link
Copy Markdown
Member

@ywangd ywangd commented Mar 6, 2026

Since #55918, snapshot creation no longer has the INIT step so that shards won't be finalized unless its state is completed. This PR removes the obsolete branch for it.

See also #143024 (comment)

@ywangd
Remove obsolete branch for finalizing incomplete shards
0b64d28 
Since elastic#55918, snapshot creation no longer has the INIT step so that
shards won't be finalized unless its state is completed. This PR removes
the obsolete branch for it.

See also elastic#143024 (comment)
@ywangd ywangd requested a review from DaveCTurner March 6, 2026 06:05
@ywangd ywangd added >non-issue :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v9.4.0 labels Mar 6, 2026
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team. label Mar 6, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Mar 6, 2026

Pinging @elastic/es-distributed (Team:Distributed)

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 6, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (2)
  • Team:Delivery
  • Team:Search - Inference

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: fdae5cd2-065d-4f8f-8292-61db3ba7024a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

DaveCTurner
DaveCTurner approved these changes Mar 6, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Normally I'd suggest we leave behind an assertion that this never happens, but (just to say it out loud) this is already covered in the remaining else branch 👍

@ywangd ywangd added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 10, 2026
@elasticsearchmachine elasticsearchmachine merged commit 2e108da into elastic:main Mar 10, 2026
36 checks passed
@ywangd ywangd deleted the remove-dead-branch-for-finalize-incomplete-shards branch March 10, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue Team:Distributed Meta label for distributed team. v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ywangd @elasticsearchmachine @DaveCTurner