ESQL: Opt into dupes when filtering#142088
Merged
nik9000 merged 3 commits intoelastic:mainfrom Feb 9, 2026
Merged
Conversation
As of elastic#142055 we track when `DocVector` contains duplicates. In that PR we said "if you call `filter`, then the result may contain duplicates." This PR adds a flag to `filter` saying "the result of this `filter` may contain duplicates." It's quite common for `filter` calls not to create duplicates and most callers can pass `false`. That'll allow block loaders that follow these `filter` calls to use faster paths.
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of #142055 we track when
DocVectorcontains duplicates. In that PR we said "if you callfilter, then the result may contain duplicates." This PR adds a flag tofiltersaying "the result of thisfiltermay contain duplicates." It's quite common forfiltercalls not to create duplicates and most callers can passfalse. That'll allow block loaders that follow thesefiltercalls to use faster paths.