Allow BytesRefArray to be shared#141968
Merged
dnhatn merged 3 commits intoelastic:mainfrom Feb 6, 2026
Merged
Conversation
49302a1 to
d3ca49f
Compare
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
kkrik-es
reviewed
Feb 6, 2026
| @@ -246,7 +246,8 @@ public BytesRefArray getBytesRefs() { | |||
|
|
|||
| public BytesRefArray takeBytesRefsOwnership() { | |||
Member
There was a problem hiding this comment.
Nit: maybe rename, e.g. sharedBytesRefs.
Member
Author
|
Thanks friends! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when building keys from BytesRefBlockHash and BytesRefLongBlockHash (used in time-series), each key must be copied. While this is acceptable for a small number of groups, the overhead becomes significant with 1M+ groups: it requires roughly twice the memory and can take seconds. This change makes BytesRefArray a RefCounted, allowing it to be shared instead of copied.