[9.3] Deep copy BytesRef when creating a constant vector block (#141242)#141530
Merged
elasticsearchmachine merged 1 commit intoelastic:9.3from Jan 29, 2026
Merged
[9.3] Deep copy BytesRef when creating a constant vector block (#141242)#141530elasticsearchmachine merged 1 commit intoelastic:9.3from
elasticsearchmachine merged 1 commit intoelastic:9.3from
Conversation
) Currently, when creating a constant BytesRef block or vector from a constant input, we do not deep copy the BytesRef in the evaluator. As a result, if the evaluator generates additional blocks afterwards, these blocks may share the underlying bytes with the constant block, leading to incorrect data. This issue was seen in tests where two rows had the same data when they should not. Closes elastic#140809 Closes elastic#140621 Closes elastic#140615
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 9.3: